Skip to content

[Improve] Streamline DCG command approval - #1062

Open
navedmerchant wants to merge 7 commits into
feat/dcg-settingfrom
feat/dcg-command-integration
Open

[Improve] Streamline DCG command approval#1062
navedmerchant wants to merge 7 commits into
feat/dcg-settingfrom
feat/dcg-command-integration

Conversation

@navedmerchant

@navedmerchant navedmerchant commented Jul 30, 2026 •
edited by zoomote Bot
Loading

Copy link
Copy Markdown
Contributor

What changed

Reads the persisted DCG setting without eagerly building full provider state, restores full state loading until after approval, and adds coverage for an allowed command continuing through execution and for command rows awaiting a decision.

Why this change was made

The DCG integration should avoid unnecessary state work on ordinary commands while preserving explicit approval for guarded commands. Closes #1058 and completes #1049.

Impact

Command approval remains responsive when DCG is disabled, while guarded-command behavior and denied-state rendering are covered more completely.

Related PRs

@navedmerchant navedmerchant added the enhancement New feature or request label Jul 30, 2026
@navedmerchant navedmerchant added the enhancement New feature or request label Jul 30, 2026
@navedmerchant navedmerchant self-assigned this Jul 30, 2026
@coderabbitai

coderabbitai Bot commented Jul 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8db70062-2a65-4f53-a0b1-297e983f1112

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@navedmerchant navedmerchant mentioned this pull request Jul 30, 2026
Closed
9 tasks
@codecov

codecov Bot commented Jul 30, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.17647% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/core/tools/ExecuteCommandTool.ts 90.47% 1 Missing and 1 partial ⚠️
src/core/task/Task.ts 50.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@github-actions github-actions Bot added the awaiting-review PR changes are ready and waiting for maintainer re-review label Jul 30, 2026
@navedmerchant
navedmerchant force-pushed the feat/dcg-command-integration branch from 3e1b109 to 5f6e0a8 Compare July 30, 2026 04:50
@github-actions github-actions Bot added awaiting-review PR changes are ready and waiting for maintainer re-review and removed awaiting-review PR changes are ready and waiting for maintainer re-review labels Jul 30, 2026
edelauna
edelauna requested changes Jul 31, 2026
View reviewed changes

@edelauna edelauna left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor questions

Comment thread src/core/auto-approval/__tests__/dcg.spec.ts
Comment thread src/core/auto-approval/index.ts
@github-actions github-actions Bot added awaiting-author PR is waiting for the author to address requested changes and removed awaiting-review PR changes are ready and waiting for maintainer re-review labels Jul 31, 2026
@navedmerchant
navedmerchant force-pushed the feat/dcg-command-integration branch from 5f6e0a8 to dd00d03 Compare August 1, 2026 17:23
@github-actions github-actions Bot removed the awaiting-author PR is waiting for the author to address requested changes label Aug 1, 2026
@navedmerchant
navedmerchant force-pushed the feat/dcg-command-integration branch from dd00d03 to e996b73 Compare August 1, 2026 17:30
@github-actions github-actions Bot added the awaiting-author PR is waiting for the author to address requested changes label Aug 1, 2026
edelauna
edelauna requested changes Aug 2, 2026
View reviewed changes

@edelauna edelauna left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had some comments related to implementation.

Comment thread src/core/tools/ExecuteCommandTool.ts Outdated
Comment thread src/core/tools/ExecuteCommandTool.ts Outdated
Comment thread src/core/tools/__tests__/executeCommandTool.spec.ts
Comment thread webview-ui/src/components/chat/__tests__/ChatRow.command-denied.spec.tsx
Comment thread webview-ui/src/components/chat/ChatRow.tsx
@github-actions github-actions Bot removed the awaiting-author PR is waiting for the author to address requested changes label Aug 2, 2026
@zoomote zoomote Bot changed the title [Feat] Integrate DCG with command auto-approval and denial UX [Improve] Streamline DCG command approval Aug 2, 2026
This was referenced Aug 2, 2026
Open
Open
@zoomote

zoomote Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Addressed the implementation and coverage feedback in 900282f. DCG reads the persisted flag cheaply before approval, preserves deferred full-state loading, and covers allow and pending chat-row paths.

@zoomote zoomote Bot mentioned this pull request Aug 2, 2026
Draft
edelauna
edelauna approved these changes Aug 2, 2026
View reviewed changes

@edelauna edelauna left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the feedback, approving - but still unclear on how you want to handle the design for a DCG blocked command: #1062 (comment)

@github-actions github-actions Bot added the awaiting-review PR changes are ready and waiting for maintainer re-review label Aug 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zoomote zoomote[bot] zoomote[bot] left review comments
@edelauna edelauna edelauna approved these changes
@taltas taltas Awaiting requested review from taltas taltas is a code owner
@JamesRobert20 JamesRobert20 Awaiting requested review from JamesRobert20 JamesRobert20 is a code owner
@hannesrudolph hannesrudolph Awaiting requested review from hannesrudolph hannesrudolph is a code owner

Assignees

@navedmerchant navedmerchant

Labels

awaiting-review PR changes are ready and waiting for maintainer re-review enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@navedmerchant @edelauna